Gecko [ www.prositehelp.com ]

Name	Size	Permission	Date
001_verify_config_arrays.sh	2.34 KB	-rw-r--r--	2026-04-01 09:39
002_check_rear_recover_mode.sh	1.95 KB	-rw-r--r--	2026-04-01 09:39
010_EFISTUB_check.sh	368 B	-rw-r--r--	2026-04-01 09:39
010_set_drlm_env.sh	135 B	-rw-r--r--	2026-04-01 09:39
030_update_recovery_system.sh	2.66 KB	-rw-r--r--	2026-04-01 09:39
100_check_stale_nfs_mounts.sh	1.15 KB	-rw-r--r--	2026-04-01 09:39
950_check_missing_programs.sh	1.93 KB	-rw-r--r--	2026-04-01 09:39
998_dump_variables.sh	1.08 KB	-rw-r--r--	2026-04-01 09:39

Rename

# Ensure that all array variables are assigned as arrays in user provided configuration.
# This avoids user config mistakes which can lead to obscure and severe errors,
# see https://github.com/rear/rear/issues/2930 and for an example
# see https://github.com/rear/rear/issues/2911
#
# Bash variables retain the array attribute even if name=value syntax is used to assign
# a new value because the new assignment changes the first member of the array.
# Therefore it is enough to take all currently defined array variables
# and check for wrong assignments in the user configuration.

# Skip this test when 'mapfile' (a bash 4.x builtin) is not available:
# sed from such old systems also don't support -E
type -a mapfile 1>/dev/null || return 0

local -a var_assignments array_variables

mapfile -t array_variables < <(
    declare -p | sed -n -E -e '/^declare -a/s/declare [-arxlu]+ ([A-Za-z0-9_-]+)=.*/\1/p'
)

for config in "$CONFIG_DIR"/{site,local,rescue}.conf "${CONFIG_APPEND_FILES_PATHS[@]}"; do
    test -r "$config" || continue
    for var in "${array_variables[@]}"; do
        # Do not check comment lines for falsely assigned array variables:
        mapfile -t var_assignments < <(
            grep -v '^[[:space:]]*#' "$config" | sed -n -E -e "/(^|\W+)$var\+?=/p"
            )
        for line in "${var_assignments[@]}"; do
            # Avoid that the [[ expression ]] could leak secrets into the ReaR log file in debugscript mode
            # for example when the assignment in $line assigns a secret value like
            #   { ARRAY=( 'secret_value' ) ; } 2>>/dev/$SECRET_OUTPUT_DEV
            # this assignment line would get shown in the ReaR log file via 'set -x' as
            #   ++ [[ { ARRAY=( secret_value ) ; } 2>>/dev/$SECRET_OUTPUT_DEV == *ARRAY?(+)=\(* ]]
            # see https://github.com/rear/rear/issues/3443
            # so avoid that by using $line within { ... } 2>>/dev/$SECRET_OUTPUT_DEV
            { [[ "$line" == *$var?(+)=\(* ]] && continue
              LogSecret "$config : $var not assigned as array : $line"
            } 2>>/dev/$SECRET_OUTPUT_DEV
            # Do not have secrets in the Error message because Error() calls LogToSyslog()
            # see https://github.com/rear/rear/pull/3449#issuecomment-2786306795
            Error "Syntax error: Variable $var not assigned as Bash array in $config"
        done
    done
done